[all-commits] [llvm/llvm-project] a95c33: [RS4GC] Add a test to demonstrate duplication of b...

Yevgeny Rouban via All-commits all-commits at lists.llvm.org
Mon Jul 12 04:13:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a95c336b5e3b72def68f75c67f3e5a134d3029e5
      https://github.com/llvm/llvm-project/commit/a95c336b5e3b72def68f75c67f3e5a134d3029e5
  Author: Yevgeny Rouban <yrouban at azul.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    A llvm/test/Transforms/RewriteStatepointsForGC/intrinsics-bare.ll

  Log Message:
  -----------
  [RS4GC] Add a test to demonstrate duplication of base generation. NFC

This new test demonstrates a case where a base ptr is generated
twice for the same value: the first one is generated while
the gc.get.pointer.base() is inlined, the second is generated
for the statepoint. This happens because the methods
inlineGetBaseAndOffset() and insertParsePoints() do not share
their defining value cache used by the findBasePointer() method.

Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D103238


  Commit: 88024a724c3bac4aa902dc85d16d3285caac4377
      https://github.com/llvm/llvm-project/commit/88024a724c3bac4aa902dc85d16d3285caac4377
  Author: Yevgeny Rouban <yrouban at azul.com>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
    M llvm/test/Transforms/RewriteStatepointsForGC/intrinsics-bare.ll

  Log Message:
  -----------
  [RS4GC] Use one DVCache for both inlineGetBaseAndOffset() and insertParsePoints()

This new test demonstrates a case where a base ptr is generated
twice for the same value: the first one is generated while
the gc.get.pointer.base() is inlined, the second is generated
for the statepoint. This happens because the methods
inlineGetBaseAndOffset() and insertParsePoints() do not share
their defining value cache used by the findBasePointer() method.

Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D103240


Compare: https://github.com/llvm/llvm-project/compare/84e429693fe5...88024a724c3b


More information about the All-commits mailing list