[all-commits] [llvm/llvm-project] b34da6: [clang] Apply MS ABI details on __builtin_ms_va_li...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Tue Jun 8 02:15:22 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b34da6ff9c1d72816d0c9b87d5f0e879850bc424
      https://github.com/llvm/llvm-project/commit/b34da6ff9c1d72816d0c9b87d5f0e879850bc424
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-08 (Tue, 08 Jun 2021)

  Changed paths:
    M clang/lib/CodeGen/TargetInfo.cpp
    M clang/test/CodeGen/ms_abi.c

  Log Message:
  -----------
  [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

This fixes inconsistencies in the ms_abi.c testcase.

Also add a couple cases of missing double pointers in the windows part
of the testcase; the outcome of building that testcase on windows hasn't
changed, but the previous form of the test was imprecise (checking
for "%[[STRUCT_FOO]]*" when clang actually generates "%[[STRUCT_FOO]]**"),
which still used to match.

Ideally this would share code with the native Windows case, but
X86_64ABIInfo and WinX86_64ABIInfo aren't superclasses/subclasses of
each other so it's impractical, and the code to share currently only
consists of a couple lines.

Differential Revision: https://reviews.llvm.org/D103837




More information about the All-commits mailing list