[all-commits] [llvm/llvm-project] 6881f2: [lld-macho] Parse re-exports of nested TAPI documents

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6881f29a36a97102e5c89653a343f656231bc2f2
      https://github.com/llvm/llvm-project/commit/6881f29a36a97102e5c89653a343f656231bc2f2
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-03 (Thu, 03 Jun 2021)

  Changed paths:
    M lld/MachO/DriverUtils.cpp
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputFiles.h
    M lld/test/MachO/tapi-link.s

  Log Message:
  -----------
  [lld-macho] Parse re-exports of nested TAPI documents

D103423 neglected to call `parseReexports()` for nested TBD
documents, leading to symbol resolution failures when trying to look up
a symbol nested more than one level deep in a TBD file. This fixes the
regression and adds a test.

It also appears that `umbrella` wasn't being set properly when calling
`parseLoadCommands` -- it's supposed to resolve to `this` if `nullptr`
is passed. I didn't write a failing test case for this but I've made
`umbrella` a member so the previous behavior should be preserved.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D103586