[all-commits] [llvm/llvm-project] 2cf78d: [libc++] Remove unused variable warnings

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cf78d4ead4a2ab5375bd6087724211d04119a28
      https://github.com/llvm/llvm-project/commit/2cf78d4ead4a2ab5375bd6087724211d04119a28
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-06-03 (Thu, 03 Jun 2021)

  Changed paths:
    M libcxx/include/regex
    M libcxx/test/std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/eval.pass.cpp
    M libcxx/test/std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp

  Log Message:
  -----------
  [libc++] Remove unused variable warnings

Since D100581, Clang started flagging this variable which is set but
never read. Based on comparing this function with __match_at_start_posix_nosubs
(which is very similar), I am pretty confident that `__j` was simply left
behind as an oversight in Howard's 6afe8b0a2336.

Also workaround some unused variable warnings in the <random> tests.
It's pretty lame that we're not asserting the skew and kurtosis of
the binomial and negative binomial distributions, but that should be
tackled separately.

Differential Revision: https://reviews.llvm.org/D103533