[all-commits] [llvm/llvm-project] dc10bf: [clangd][Protocol] Drop optional from WorkspaceEdi...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Wed Jun 2 14:03:50 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc10bf1a4ed0b34b27284b5260ce5c6cc132bd6f
      https://github.com/llvm/llvm-project/commit/dc10bf1a4ed0b34b27284b5260ce5c6cc132bd6f
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-06-02 (Wed, 02 Jun 2021)

  Changed paths:
    M clang-tools-extra/clangd/ClangdLSPServer.cpp
    M clang-tools-extra/clangd/Diagnostics.cpp
    M clang-tools-extra/clangd/Protocol.cpp
    M clang-tools-extra/clangd/Protocol.h

  Log Message:
  -----------
  [clangd][Protocol] Drop optional from WorkspaceEdit::changes

This is causing weird code patterns in various places and I can't see
any difference between None and empty change list. Neither in the current use
cases nor in the spec.

Differential Revision: https://reviews.llvm.org/D103449




More information about the All-commits mailing list