[all-commits] [llvm/llvm-project] 644f72: [mlir-lsp] Report range of potential identifier st...

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Wed Jun 2 10:51:46 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 644f722b369d9d7e0bef3694d11c48d7d333d36a
      https://github.com/llvm/llvm-project/commit/644f722b369d9d7e0bef3694d11c48d7d333d36a
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2021-06-02 (Wed, 02 Jun 2021)

  Changed paths:
    M mlir/include/mlir/Parser/AsmParserState.h
    M mlir/lib/Parser/AsmParserState.cpp
    M mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp
    M mlir/test/mlir-lsp-server/diagnostics.test

  Log Message:
  -----------
  [mlir-lsp] Report range of potential identifier starting at location of diagnostic

Currently the diagnostics reports the file:line:col, but some LSP
frontends require a non-empty range. Report either the range of an
identifier that starts at location, or a range of 1. Expose the id
location to range helper and reuse here.

Differential Revision: https://reviews.llvm.org/D103482




More information about the All-commits mailing list