[all-commits] [llvm/llvm-project] d54712: [libomptarget][amdgpu] Mark alloc, free weak to fa...

[Jon Chesterfield via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d54712ab4deb5b83ef58db73ce18ed466201f4e1
      https://github.com/llvm/llvm-project/commit/d54712ab4deb5b83ef58db73ce18ed466201f4e1
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-05-21 (Fri, 21 May 2021)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip

  Log Message:
  -----------
  [libomptarget][amdgpu] Mark alloc, free weak to facilitate local experimentation

[libomptarget][amdgpu] Mark alloc, free weak to facilitate local experimentation

There are a lot of different ways we might implement the devicertl local alloc
and free functions. Via host, local buffers (stack or arena), specialising per
kernel etc. It is not yet clear what the right design is. This change makes the
alloc and free functions weak, so one can override them from local tests while
comparing options.

Not strictly necessary, as a comparable patch can be applied locally each time,
but would be convenient for out of tree dev. Plan would be to drop the weak
attribute at the same time as introducing a working allocator to trunk.

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D102499