[all-commits] [llvm/llvm-project] 35e5c3: [X86] Pre-commit test for D90901

Jim Lin via All-commits all-commits at lists.llvm.org
Fri May 21 07:59:59 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35e5c3310fb0d974b6a151c775ac46a3c3a0e151
      https://github.com/llvm/llvm-project/commit/35e5c3310fb0d974b6a151c775ac46a3c3a0e151
  Author: Jim Lin <jim at andestech.com>
  Date:   2021-05-21 (Fri, 21 May 2021)

  Changed paths:
    A llvm/test/CodeGen/X86/fma-signed-zero.ll

  Log Message:
  -----------
  [X86] Pre-commit test for D90901

Differential Revision: https://reviews.llvm.org/D102621


  Commit: 445680593889199667d60207e302bc870f650fa5
      https://github.com/llvm/llvm-project/commit/445680593889199667d60207e302bc870f650fa5
  Author: Jim Lin <jim at andestech.com>
  Date:   2021-05-21 (Fri, 21 May 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/test/CodeGen/X86/avx2-fma-fneg-combine.ll
    M llvm/test/CodeGen/X86/fma-fneg-combine.ll
    M llvm/test/CodeGen/X86/fma-signed-zero.ll
    M llvm/test/CodeGen/X86/fma_patterns.ll
    M llvm/test/CodeGen/X86/fma_patterns_wide.ll

  Log Message:
  -----------
  [X86] Don't fold (fneg (fma (fneg X), Y, (fneg Z))) to (fma X, Y, Z)

Check if it has no signed zeros flag (nsz) in getNegatedExpression for x86.
This patch fixed miscompilation: https://alive2.llvm.org/ce/z/XxwBAJ

Reviewed By: RKSimon, spatel

Differential Revision: https://reviews.llvm.org/D90901


Compare: https://github.com/llvm/llvm-project/compare/cea7a3fe3d1f...445680593889


More information about the All-commits mailing list