[all-commits] [llvm/llvm-project] 2db090: [llvm][AsmPrinter] Restore source location to regi...

David Spickett via All-commits all-commits at lists.llvm.org
Fri May 14 01:23:16 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2db090a2ebd76f120bfae4fbe4b7241667aa585e
      https://github.com/llvm/llvm-project/commit/2db090a2ebd76f120bfae4fbe4b7241667aa585e
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    A clang/test/Misc/inline-asm-clobber-warning.c
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp

  Log Message:
  -----------
  [llvm][AsmPrinter] Restore source location to register clobber warning

Since 5de2d189e6ad466a1f0616195e8c524a4eb3cbc0 this particular warning
hasn't had the location of the source file containing the inline
assembly.

Fix this by reporting via LLVMContext. Which means that we no longer
have the "instantiated into assembly here" lines but they were going to
point to the start of the inline asm string anyway.

This message is already tested via IR in llvm. However we won't have
the required location info there so I've added a C file test in clang
to cover it.
(though strictly, this is testing llvm code)

Reviewed By: ychen

Differential Revision: https://reviews.llvm.org/D102244




More information about the All-commits mailing list