[all-commits] [llvm/llvm-project] 34a8a4: [NewPM] Hide pass manager debug logging behind -de...

aeubanks via All-commits all-commits at lists.llvm.org
Fri May 7 21:52:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34a8a437bf20e0a340c19ed1fdb9cca584d43da1
      https://github.com/llvm/llvm-project/commit/34a8a437bf20e0a340c19ed1fdb9cca584d43da1
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2021-05-07 (Fri, 07 May 2021)

  Changed paths:
    M clang/lib/CodeGen/BackendUtil.cpp
    M clang/test/CodeGen/lto-newpm-pipeline.c
    M clang/test/CodeGen/thinlto-distributed-newpm.ll
    M clang/test/CodeGenCoroutines/coro-newpm-pipeline.cpp
    M lld/test/COFF/lto-new-pass-manager.ll
    M lld/test/ELF/lto/new-pass-manager.ll
    M lld/test/wasm/lto/new-pass-manager.ll
    M llvm/include/llvm/CodeGen/MachinePassManager.h
    M llvm/include/llvm/IR/PassManager.h
    M llvm/include/llvm/Passes/PassBuilder.h
    M llvm/include/llvm/Target/TargetMachine.h
    M llvm/include/llvm/Transforms/IPO/Inliner.h
    M llvm/include/llvm/Transforms/Scalar/LoopPassManager.h
    M llvm/lib/Analysis/CGSCCPassManager.cpp
    M llvm/lib/CodeGen/MachinePassManager.cpp
    M llvm/lib/LTO/LTOBackend.cpp
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/lib/Passes/StandardInstrumentations.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
    M llvm/lib/Target/BPF/BPFTargetMachine.cpp
    M llvm/lib/Target/BPF/BPFTargetMachine.h
    M llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
    M llvm/lib/Target/Hexagon/HexagonTargetMachine.h
    M llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
    M llvm/lib/Target/NVPTX/NVPTXTargetMachine.h
    M llvm/lib/Transforms/IPO/Inliner.cpp
    M llvm/lib/Transforms/Scalar/LoopPassManager.cpp
    M llvm/test/Other/loop-pm-invalidation.ll
    M llvm/test/Other/new-pass-manager-cgscc-fct-proxy.ll
    M llvm/test/Other/new-pass-manager.ll
    M llvm/test/Other/new-pm-O0-defaults.ll
    M llvm/test/Other/new-pm-defaults.ll
    M llvm/test/Other/new-pm-lto-defaults.ll
    M llvm/test/Other/new-pm-pgo-preinline.ll
    M llvm/test/Other/new-pm-thinlto-defaults.ll
    M llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
    M llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
    M llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
    M llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll
    M llvm/test/Other/pass-pipeline-parsing.ll
    M llvm/test/Transforms/Inline/cgscc-incremental-invalidate.ll
    M llvm/test/Transforms/Inline/clear-analyses.ll
    M llvm/test/Transforms/LoopRotate/pr35210.ll
    M llvm/test/Transforms/LoopUnroll/unroll-loop-invalidation.ll
    M llvm/test/Transforms/SCCP/ipsccp-preserve-analysis.ll
    M llvm/test/Transforms/SCCP/preserve-analysis.ll
    M llvm/test/Transforms/SROA/dead-inst.ll
    M llvm/test/tools/gold/X86/new-pm.ll
    M llvm/tools/llvm-opt-fuzzer/llvm-opt-fuzzer.cpp
    M llvm/tools/opt/NewPMDriver.cpp
    M llvm/unittests/Analysis/CGSCCPassManagerTest.cpp
    M llvm/unittests/IR/PassBuilderCallbacksTest.cpp
    M llvm/unittests/IR/PassManagerTest.cpp
    M llvm/unittests/Transforms/Scalar/LoopPassManagerTest.cpp
    M polly/lib/Support/RegisterPasses.cpp

  Log Message:
  -----------
  [NewPM] Hide pass manager debug logging behind -debug-pass-manager-verbose

Printing pass manager invocations is fairly verbose and not super
useful.

This allows us to remove DebugLogging from pass managers and PassBuilder
since all logging (aside from analysis managers) goes through
instrumentation now.

This has the downside of never being able to print the top level pass
manager via instrumentation, but that seems like a minor downside.

Reviewed By: ychen

Differential Revision: https://reviews.llvm.org/D101797




More information about the All-commits mailing list