[all-commits] [llvm/llvm-project] 223852: [DebugInfo] UnwindTable::create() should not add e...

RamNalamothu via All-commits all-commits at lists.llvm.org
Fri May 7 21:49:32 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 223852d76fccc85cc5a844feec94781e8c5320ff
      https://github.com/llvm/llvm-project/commit/223852d76fccc85cc5a844feec94781e8c5320ff
  Author: RamNalamothu <VenkataRamanaiah.Nalamothu at amd.com>
  Date:   2021-05-08 (Sat, 08 May 2021)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp

  Log Message:
  -----------
  [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table

UnwindTable::parseRows() may return successfully if the CFIProgram has either
no CFI instructions or only DW_CFA_nop instructions and the UnwindRow return
argument will be empty. But currently, the callers are not checking for this case
which is leading to incorrect dumps in the unwind tables in such cases i.e.

  CFA=unspecified

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D101892




More information about the All-commits mailing list