[all-commits] [llvm/llvm-project] 1afdd3: [SCEV] Add additional NE applyLoopGuards() test (NFC)

Nikita Popov via All-commits all-commits at lists.llvm.org
Sat Apr 24 12:47:05 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1afdd361a233c2ca2df0bac64ee71918e9705cd7
      https://github.com/llvm/llvm-project/commit/1afdd361a233c2ca2df0bac64ee71918e9705cd7
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info.ll

  Log Message:
  -----------
  [SCEV] Add additional NE applyLoopGuards() test (NFC)

This is the same as @test_guard_ult_ne, just with the order of
the conditions swapped.


  Commit: a5051f2fa2f20405a7cd0630067afc338f6c6d44
      https://github.com/llvm/llvm-project/commit/a5051f2fa2f20405a7cd0630067afc338f6c6d44
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M llvm/lib/Analysis/ScalarEvolution.cpp
    M llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info.ll

  Log Message:
  -----------
  [SCEV] Fix applyLoopGuards() chaining for ne predicates

ICMP_NE predicates directly overwrote the rewritten result,
instead of chaining it with previous rewrites, as was done for
ICMP_ULT and ICMP_ULE. This means that some guards were effectively
discarded, depending on their order.


Compare: https://github.com/llvm/llvm-project/compare/95af97176418...a5051f2fa2f2


More information about the All-commits mailing list