[all-commits] [llvm/llvm-project] 035eb6: [lld-macho]][nfc] Fix some typos + rephrase a comment

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 035eb6d154a1f4827eabc29d02d17e69fc939202
      https://github.com/llvm/llvm-project/commit/035eb6d154a1f4827eabc29d02d17e69fc939202
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-23 (Fri, 23 Apr 2021)

  Changed paths:
    M lld/MachO/SyntheticSections.cpp
    M lld/test/MachO/private-extern.s

  Log Message:
  -----------
  [lld-macho]][nfc] Fix some typos + rephrase a comment

I was a bit confused by the comment because I thought that "Tests
that..." was describing the tests contained within the same file.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D101160


  Commit: 3fe5c3b0189f51868493bbbc6768ef3afbdfb492
      https://github.com/llvm/llvm-project/commit/3fe5c3b0189f51868493bbbc6768ef3afbdfb492
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-23 (Fri, 23 Apr 2021)

  Changed paths:
    M lld/MachO/DriverUtils.cpp
    M lld/MachO/InputFiles.h

  Log Message:
  -----------
  [lld-macho] Fix use-after-free in loadDylib()

We were taking a reference to a value in `loadedDylibs`, which in turn
called `make<DylibFile>()`, which could then recursively call
`loadDylibs`, which would then potentially resize `loadedDylibs` and
invalidate that reference.

Fixes PR50101.

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D101175


Compare: https://github.com/llvm/llvm-project/compare/9658d0459265...3fe5c3b0189f