[all-commits] [llvm/llvm-project] eae7f3: [lit] Pass the USERPROFILE variable through on Win...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Thu Apr 22 23:23:55 PDT 2021


  Branch: refs/heads/release/12.x
  Home:   https://github.com/llvm/llvm-project
  Commit: eae7f3e3d45077a509a37bb2f2ff36b8196a855e
      https://github.com/llvm/llvm-project/commit/eae7f3e3d45077a509a37bb2f2ff36b8196a855e
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-23 (Fri, 23 Apr 2021)

  Changed paths:
    M llvm/utils/lit/lit/TestingConfig.py

  Log Message:
  -----------
  [lit] Pass the USERPROFILE variable through on Windows

When running in a Windows Container, the Git for Windows Unix tools
(C:\Program Files\Git\usr\bin) just hang if this variable isn't
passed through.

Currently, running the LLVM/clang tests in a Windows Container fails
if that directory is added to the path, but succeeds after this change.
(After this change, the previously used GnuWin tools can be left out
entirely, too, as lit automatically picks up the Git for Windows tools
if necessary.)

Differential Revision: https://reviews.llvm.org/D98858

(cherry picked from commit 9de63b2e051cb3e79645cc20b83b4d33d132cba0)


  Commit: 072c90a863aac1334a4950b3da262a025516dea0
      https://github.com/llvm/llvm-project/commit/072c90a863aac1334a4950b3da262a025516dea0
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-04-23 (Fri, 23 Apr 2021)

  Changed paths:
    M lld/test/lit.cfg.py

  Log Message:
  -----------
  [LLD] Fix probing a MSYS based 'tar' in a Windows Container

Don't run the 'tar' tool in a cleared environment with only the
LANG variable set, just set LANG on top of the existing environment.

If the 'tar' tool is an MSYS based tool, running it in a Windows
Container hangs if all environment variables are cleared - in
particular, the USERPROFILE variable needs to be kept intact.

This is the same issue fixed as was fixed in other places in
9de63b2e051cb3e79645cc20b83b4d33d132cba0, but contrary to running
the actual tests, running with an as-cleared-as-possible environment
here is less important.

Differential Revision: https://reviews.llvm.org/D99304

(cherry picked from commit a88556733a4dced22416bd3f45255128b9eb4f49)


Compare: https://github.com/llvm/llvm-project/compare/757752f568db...072c90a863aa


More information about the All-commits mailing list