[all-commits] [llvm/llvm-project] 8c17a8: [re-land][lld-macho] Fix min version check

Jez Ng via All-commits all-commits at lists.llvm.org
Thu Apr 22 16:35:50 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c17a875150f8e736e8f9061ddf084397f45f4c5
      https://github.com/llvm/llvm-project/commit/8c17a875150f8e736e8f9061ddf084397f45f4c5
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-04-22 (Thu, 22 Apr 2021)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/test/MachO/compact-unwind-generated.test
    M lld/test/MachO/compact-unwind.s
    M lld/test/MachO/internalize.ll
    M lld/test/MachO/invalid/compact-unwind-bad-reloc.s
    M lld/test/MachO/invalid/compact-unwind-personalities.s
    M lld/test/MachO/invalid/incompatible-arch.s
    M lld/test/MachO/invalid/invalid-relocation-length.yaml
    M lld/test/MachO/invalid/invalid-relocation-pcrel.yaml
    M lld/test/MachO/lc-linker-option.ll
    M lld/test/MachO/linkonce.ll
    M lld/test/MachO/lto-archive.ll
    M lld/test/MachO/lto-object-path.ll
    M lld/test/MachO/lto-save-temps.ll
    M lld/test/MachO/mh-header-link.s
    M lld/test/MachO/module-asm.ll
    M lld/test/MachO/t.s
    M lld/test/MachO/tapi-link-by-arch.s

  Log Message:
  -----------
  [re-land][lld-macho] Fix min version check

We had got it backwards... the minimum version of the target
should be higher than the min version of the object files, presumably
since new platforms are backwards-compatible with older formats.

Fixes PR50078.

The original commit (aa05439c9cde) broke many tests that had inputs too
new for our target platform (10.0). This commit changes the inputs to
target 10.0, which was the simpler thing to do, but we should really
just have our lit.local.cfg default to targeting 10.15... we're not
likely to ever have proper support for the older versions anyway. I will
follow up with a change to that effect.

Differential Revision: https://reviews.llvm.org/D101114




More information about the All-commits mailing list