[all-commits] [llvm/llvm-project] 89b593: [PollyACC] Fix declaration/stub definition mismatc...

Michael Kruse via All-commits all-commits at lists.llvm.org
Wed Apr 21 09:53:13 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 89b59345ee29d2cc1afa1f60445916ae2e74be6d
      https://github.com/llvm/llvm-project/commit/89b59345ee29d2cc1afa1f60445916ae2e74be6d
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2021-04-21 (Wed, 21 Apr 2021)

  Changed paths:
    M polly/lib/External/ppcg/external.c

  Log Message:
  -----------
  [PollyACC] Fix declaration/stub definition mismatch. NFC.

external.c defines stub functions that are never used because of how
Polly uses PPCG. Unfortunately, they are declared as functions without
return values or parameters which does not match their declarations.
Since they are never called, this was usually not a problem, but an LTO
build gets confused with differently declared functions, or in case of
pet_options_args, a global variable declaration that is defined as a
function

Resolve by including the declaring headers in external.c which forces
the declaration and definition to match at compile-time.

This fixes llvm.org/50021




More information about the All-commits mailing list