[all-commits] [llvm/llvm-project] ca9b7e: [AArch64][SVE] Fix crash with icmp+select

CarolineConcatto via All-commits all-commits at lists.llvm.org
Wed Apr 21 06:17:04 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ca9b7e2e2f0897dade16d785dafadbf75deaf405
      https://github.com/llvm/llvm-project/commit/ca9b7e2e2f0897dade16d785dafadbf75deaf405
  Author: Caroline Concatto <caroline.concatto at arm.com>
  Date:   2021-04-21 (Wed, 21 Apr 2021)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
    M llvm/lib/Target/AArch64/SVEInstrFormats.td
    M llvm/test/CodeGen/AArch64/sve-select.ll

  Log Message:
  -----------
  [AArch64][SVE] Fix crash with icmp+select

This patch changes the lowering of SELECT_CC from Legal to Expand for scalable
vector and adds support for scalable vectors in performSelectCombine.

When selecting the nodes to lower in visitSELECT it checks if it is possible to
use SELECT_CC in cases where SETCC is followed by SELECT. visistSELECT checks
if SELECT_CC is legal or custom to replace SELECT by SELECT_CC.
SELECT_CC used to be legal for scalable vector, so the node changes to
SELECT_CC. This used to crash the compiler as there is no support for SELECT_CC
with scalable vectors. So now the compiler lowers to VSELECT instead of
SELECT_CC.

Differential Revision: https://reviews.llvm.org/D100485




More information about the All-commits mailing list