[all-commits] [llvm/llvm-project] 90e5ce: [PollyACC] Fix implicit function definitions. NFC.

Michael Kruse via All-commits all-commits at lists.llvm.org
Tue Apr 20 23:09:08 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 90e5ce0b0d6b0e72fdc034cbb612f67d67de0fdd
      https://github.com/llvm/llvm-project/commit/90e5ce0b0d6b0e72fdc034cbb612f67d67de0fdd
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2021-04-21 (Wed, 21 Apr 2021)

  Changed paths:
    M polly/lib/External/ppcg/print.c

  Log Message:
  -----------
  [PollyACC] Fix implicit function definitions. NFC.

The isl_id_* have been in used without including the correspodning
isl/id.h header. According to rules in C, a function is defined
implicitly when first used with an assumed int return type (32 bits on
64 bit systems). But the implementation returns a pointer (64 bits on 64
bit systems). Is usually has no consequence because the return value is
stored in a registers that is 64 bits (RAX) and the optimizer does not
truncate its value before using it again as a pointer value. However,
LTO optimizers will be rightfull;y confused.

Fix by including <isl/id.h>

This fixes llvm.org/PR50021


  Commit: 6048d1d19c55a107f67cd617d6ed386831b5adee
      https://github.com/llvm/llvm-project/commit/6048d1d19c55a107f67cd617d6ed386831b5adee
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2021-04-21 (Wed, 21 Apr 2021)

  Changed paths:
    M polly/lib/External/CMakeLists.txt

  Log Message:
  -----------
  [PollyACC] Configure PollyPPCG only if needed.

The PollyPPCG library is only needed when POLLY_ENABLE_GPGPU_CODEGEN=ON.
If disabled, the library target is still created, but not linked against
anything.

This change does not add create the PollyPPCG build target if not
needed.

Motivated by llvm.org/PR50021


Compare: https://github.com/llvm/llvm-project/compare/f76fb7d42033...6048d1d19c55


More information about the All-commits mailing list