[all-commits] [llvm/llvm-project] 16a0d8: [CMake][llvm] avoid changing global flags (may be ...

Visoiu Mistrih Francis via All-commits all-commits at lists.llvm.org
Tue Apr 20 16:07:26 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 16a0d80912ed9840756edf8b85356cea09456eec
      https://github.com/llvm/llvm-project/commit/16a0d80912ed9840756edf8b85356cea09456eec
  Author: Jim Radford <jradford at apple.com>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M llvm/cmake/modules/HandleLLVMOptions.cmake

  Log Message:
  -----------
  [CMake][llvm] avoid changing global flags (may be used outside of llvm)

Changing global flags can break builds of projects that include/build
llvm as a sub-project, as the effect is global. Ideally we would
disable this warning at the directory level instead, but the obvious
way (disabling warning D9025) isn't supported. At least we can limit
the effect to only MSVC.

Patch by Jim Radford.

Differential Revision: https://reviews.llvm.org/D100900




More information about the All-commits mailing list