[all-commits] [llvm/llvm-project] 4a292e: [libcxx][test] Construct non-empty containers in i...

chbessonova via All-commits all-commits at lists.llvm.org
Tue Apr 20 10:52:27 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4a292eda25bc999ec175f0d21b87cb0225b6da86
      https://github.com/llvm/llvm-project/commit/4a292eda25bc999ec175f0d21b87cb0225b6da86
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_iterators_9.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_7.pass.cpp
    M libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_9.pass.cpp

  Log Message:
  -----------
  [libcxx][test] Construct non-empty containers in iterator's debug mode tests

The debug mode tests for map/set's iterators construct empty
containers, making the code after the first increment meaningless.
It's never executed since the tests exit earlier.

It doesn't seem to be intentional, so the patch makes the tests
to construct containers that include at least one element.

Reviewed By: curdeius, Quuxplusone

Differential Revision: https://reviews.llvm.org/D100029




More information about the All-commits mailing list