[all-commits] [llvm/llvm-project] fd9410: Fix PR46880: Fail CHECK-NOT with undefined variable

RoboTux via All-commits all-commits at lists.llvm.org
Tue Apr 20 06:42:50 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fd941036bf2494cfbd2749f2f179733cbe9e2eb4
      https://github.com/llvm/llvm-project/commit/fd941036bf2494cfbd2749f2f179733cbe9e2eb4
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M llvm/lib/FileCheck/FileCheck.cpp
    M llvm/lib/FileCheck/FileCheckImpl.h
    M llvm/test/FileCheck/dump-input/annotations.txt
    M llvm/test/FileCheck/match-time-error-propagation/invalid-excluded-pattern.txt
    M llvm/test/FileCheck/match-time-error-propagation/invalid-expected-pattern.txt
    M llvm/test/FileCheck/numeric-expression.txt
    M llvm/test/FileCheck/var-scope.txt
    M llvm/unittests/FileCheck/FileCheckTest.cpp

  Log Message:
  -----------
  Fix PR46880: Fail CHECK-NOT with undefined variable

Currently a CHECK-NOT directive succeeds whenever the corresponding
match fails. However match can fail due to an error rather than a lack
of match, for instance if a variable is undefined. This commit makes match
error a failure for CHECK-NOT.

Reviewed By: jdenny

Differential Revision: https://reviews.llvm.org/D86222




More information about the All-commits mailing list