[all-commits] [llvm/llvm-project] 2226d2: [MCA][LSUnit] Fix a potential use after free in th...

Andrea Di Biagio via All-commits all-commits at lists.llvm.org
Tue Apr 20 05:34:08 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2226d21896d6d30d51e13385361ea0706ee9d9fb
      https://github.com/llvm/llvm-project/commit/2226d21896d6d30d51e13385361ea0706ee9d9fb
  Author: Andrea Di Biagio <andrea.dibiagio at sony.com>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M llvm/include/llvm/MCA/HardwareUnits/LSUnit.h
    M llvm/lib/MCA/HardwareUnits/LSUnit.cpp

  Log Message:
  -----------
  [MCA][LSUnit] Fix a potential use after free in the logic that updates memory groups.

Make sure that the `CriticalMemoryInstruction` of a memory group is invalidated
if it references an already executed instruction.  This avoids a potential
use-after-free if the critical memory info becomes stale, and the value is
read after the instruction has executed.




More information about the All-commits mailing list