[all-commits] [llvm/llvm-project] 044196: [AMDGPU, test] Fix use of undef FileCheck var

RoboTux via All-commits all-commits at lists.llvm.org
Thu Apr 8 01:43:17 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04419628e011d32a1b3dd8efd981ed9e978bf43d
      https://github.com/llvm/llvm-project/commit/04419628e011d32a1b3dd8efd981ed9e978bf43d
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2021-04-08 (Thu, 08 Apr 2021)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll
    M llvm/test/CodeGen/AMDGPU/private-memory-r600.ll

  Log Message:
  -----------
  [AMDGPU, test] Fix use of undef FileCheck var

Test CodeGen/AMDGPU/amdgpu.private-memory.ll and
CodeGen/AMDGPU/private-memory-r600.ll have a block of CHECK directives
whose prefix is inconsistent: R600-CHECK Vs R600. This leads to a
R600-NOT directive using an undefined CHAN variable due to R600-CHECK
directives never being considered by FileCheck. Fixing the prefix leads
to the testcase failing. As per https://reviews.llvm.org/D99865#2675235
this commit removes the directives instead since it is not possible to
write a reliable check.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D99865




More information about the All-commits mailing list