[all-commits] [llvm/llvm-project] a7afc8: [flang] Fix CHECK() calls on erroneous procedure d...

[Pete Steinfeld via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a7afc8a51471bdfd0c597f8e885dbddada7f590a
      https://github.com/llvm/llvm-project/commit/a7afc8a51471bdfd0c597f8e885dbddada7f590a
  Author: Peter Steinfeld <psteinfeld at nvidia.com>
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
    M flang/lib/Semantics/resolve-names.cpp
    M flang/test/Semantics/resolve18.f90

  Log Message:
  -----------
  [flang] Fix CHECK() calls on erroneous procedure declarations

When writing tests for a previous problem, I ran across situations where the
compiler was failing calls to CHECK().  In these situations, the compiler had
inconsistent semantic information because the programs were erroneous.  This
inconsistent information was causing the calls to CHECK().

I fixed this by avoiding the code that ended up making the failed calls to
CHECK() and making sure that we were only avoiding these situations when the
associated symbols were erroneous.

I also added tests that would cause the calls to CHECK() without these changes.

Differential Revision: https://reviews.llvm.org/D99342