[all-commits] [llvm/llvm-project] e089b5: [lldb] Call os_log_fault on lldb_assert

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e089b5e9e11a61be0a11378f8df9af806807bddc
      https://github.com/llvm/llvm-project/commit/e089b5e9e11a61be0a11378f8df9af806807bddc
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M lldb/include/lldb/Utility/LLDBAssert.h
    M lldb/source/Utility/LLDBAssert.cpp
    A lldb/test/Shell/Error/assert.test
    M lldb/tools/lldb-test/lldb-test.cpp

  Log Message:
  -----------
  [lldb] Call os_log_fault on lldb_assert

Call `os_log_fault` when an lldb assert fails. We piggyback off
`LLVM_SUPPORT_XCODE_SIGNPOSTS`, which also depends on `os_log`, to avoid
having to introduce another CMake check and corresponding define.

This patch also adds a small test using lldb-test that verifies we abort
with a "regular" assertion when asserts are enabled.

Differential revision: https://reviews.llvm.org/D98987