[all-commits] [llvm/llvm-project] 9406d4: Make the stop-on-sharedlibrary-events setting work.

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9406d43138811ac4dfd0ab31434f65a649bc882e
      https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e
  Author: Jim Ingham <jingham at apple.com>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M lldb/source/Breakpoint/BreakpointOptions.cpp
    M lldb/source/Target/StopInfo.cpp
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/Makefile
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/a.cpp
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/b.cpp
    A lldb/test/API/functionalities/stop-on-sharedlibrary-load/main.cpp

  Log Message:
  -----------
  Make the stop-on-sharedlibrary-events setting work.

We weren't taking into account the "m_should_stop" setting that the
synchronous breakpoint callback had already set when we did PerformAction
in the StopInfoBreakpoint.  So we didn't obey its instructions when it
told us to stop.  Fixed that and added some tests both for when we
just have the setting, and when we have the setting AND other breakpoints
at the shared library load notification breakpoint address.

Differential Revision: https://reviews.llvm.org/D98914