[all-commits] [llvm/llvm-project] cfa65f: [cmake] Enable Clang warnings about redundant semi...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cfa65f77cbcd1185bdd3860ff326db37066a519a
      https://github.com/llvm/llvm-project/commit/cfa65f77cbcd1185bdd3860ff326db37066a519a
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M llvm/cmake/modules/HandleLLVMOptions.cmake

  Log Message:
  -----------
  [cmake] Enable Clang warnings about redundant semicolons

This matches what GCC warns about when -pedantic is enabled.

This should avoid such redundant semicolons creeping into the codebase.

Differential Revision: https://reviews.llvm.org/D98941


  Commit: 7a154c32301de7241ea9ea7b05afad0bbdb76f9c
      https://github.com/llvm/llvm-project/commit/7a154c32301de7241ea9ea7b05afad0bbdb76f9c
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.relative/relative.pass.cpp
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.weakly_canonical/weakly_canonical.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Account for differences in a trailing slash in weakly_canonical

This seems to be a documented quirk in libc++'s implementation of
weakly_canonical (in a comment in the weakly_canonical test).
Together with a difference between windows and posix regarding whether
paths can go through nonexistent dirs, this results in a difference in
a trailing slash.

Just document this as expected, and degrade the comment from fixme to
a note, as MS STL and libstdc++ behave in the same way.

Differential Revision: https://reviews.llvm.org/D98642


Compare: https://github.com/llvm/llvm-project/compare/87248e852b71...7a154c32301d