[all-commits] [llvm/llvm-project] f3dd78: Revert "[lit] Handle plain negations directly in t...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3dd783b239f5587213d528dc642b599f43452b6
      https://github.com/llvm/llvm-project/commit/f3dd783b239f5587213d528dc642b599f43452b6
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M llvm/utils/lit/lit/TestRunner.py

  Log Message:
  -----------
  Revert "[lit] Handle plain negations directly in the internal shell"

This reverts commit d09adfd3993cbc1043b4d20232bce8bd774232cc.

That commit caused failures in
clang-tidy/infrastructure/validate-check-names.cpp on windows
buildbots.

That change exposed a surprising issue, not directly related to
this change in itself, but in how TestRunner quotes command line
arguments that later are going to be interpreted by a msys based
tool (like grep.exe, when provided by Git for Windows). This
worked accidentally before, when grep was invoked via not.exe
which took a more conservative approach to windows argument quoting.