[all-commits] [llvm/llvm-project] d09adf: [lit] Handle plain negations directly in the inter...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Mar 19 00:34:02 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d09adfd3993cbc1043b4d20232bce8bd774232cc
      https://github.com/llvm/llvm-project/commit/d09adfd3993cbc1043b4d20232bce8bd774232cc
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M llvm/utils/lit/lit/TestRunner.py

  Log Message:
  -----------
  [lit] Handle plain negations directly in the internal shell

Keep running "not --crash" via the external "not" executable, but
for plain negations, and for cases that use the shell "!" operator,
just skip that argument and invert the return code.

The libcxx tests only use the shell operator "!" for negations,
never the "not" executable, because libcxx tests can be run without
having a fully built llvm tree available providing the "not"
executable.

This allows using the internal shell for libcxx tests.

Differential Revision: https://reviews.llvm.org/D98859


  Commit: c9fc1a979cbaf86b00e66140a235f5fdc1250bc5
      https://github.com/llvm/llvm-project/commit/c9fc1a979cbaf86b00e66140a235f5fdc1250bc5
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-19 (Fri, 19 Mar 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Explicitly check that some env vars are ignored in the temp_dir_path test

This was suggested in the review of D98139.

Differential Revision: https://reviews.llvm.org/D98696


Compare: https://github.com/llvm/llvm-project/compare/a1d6c652e3a0...c9fc1a979cba


More information about the All-commits mailing list