[all-commits] [llvm/llvm-project] d7fed7: [AArch64][GlobalISel] Fall back if disabling neon/...
Amara Emerson via All-commits
all-commits at lists.llvm.org
Wed Mar 17 15:08:38 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: d7fed7b8994eb239cde727eb826d6fa43732e7a5
https://github.com/llvm/llvm-project/commit/d7fed7b8994eb239cde727eb826d6fa43732e7a5
Author: Amara Emerson <amara at apple.com>
Date: 2021-03-17 (Wed, 17 Mar 2021)
Changed paths:
M llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
M llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
M llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
M llvm/lib/Target/AArch64/GISel/AArch64CallLowering.h
M llvm/test/CodeGen/AArch64/GlobalISel/no-neon-no-fp.ll
Log Message:
-----------
[AArch64][GlobalISel] Fall back if disabling neon/fp in the translator.
The previous technique relied on early-exiting the legalizer predicate
initialization, leaving an empty rule table. That causes a fallback
for most instructions, but some have legacy rules defined like G_ZEXT
which can try continue, but then crash.
We should fall back earlier, in the translator, to avoid this issue.
Differential Revision: https://reviews.llvm.org/D98730
More information about the All-commits
mailing list