[all-commits] [llvm/llvm-project] 605a50: [lld-link] emit an error when writing a PDB > 4 GiB

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 605a503f35063daf9ff264592caee713e85571e4
      https://github.com/llvm/llvm-project/commit/605a503f35063daf9ff264592caee713e85571e4
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
    M llvm/lib/DebugInfo/MSF/MSFBuilder.cpp

  Log Message:
  -----------
  [lld-link] emit an error when writing a PDB > 4 GiB

Maybe there's a way to make them work, but until I've investigated
if tools can consume large PDBs, erroring out is better than slowly
and silently consuming all available ram due to internal invariants
being violated.

(Patch to make writing larger files work at
https://bugs.chromium.org/p/chromium/issues/detail?id=1179085#c25
but I haven't had time to check if windbg & co can consume these
large PDBs. llvm-pdbutil can't, but we can fix that one at least :) )

Differential Revision: https://reviews.llvm.org/D98788