[all-commits] [llvm/llvm-project] 9cf21d: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9cf21da776b5e71da46826ba941147495285f106
      https://github.com/llvm/llvm-project/commit/9cf21da776b5e71da46826ba941147495285f106
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-03-17 (Wed, 17 Mar 2021)

  Changed paths:
    M lldb/test/API/tools/lldb-server/TestGdbRemote_vContThreads.py

  Log Message:
  -----------
  [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

The TestGdbRemote_vContThreads.py were introduced to test NetBSD process
plugin's capability of sending per-thread and per-process signals.
However, at some point the tests started failing.  From retrospective,
it is possible that they were relying on some bug in the plugin's
original signal handling.

Fix the tests not to expect the process to terminate after receiving
the signals.  Instead, scan for output indicating that the signals were
received and match thread IDs in it.  Enable 'signal to all threads'
test everywhere as it works fine on Linux.  Add a new test for vCont
packet without specific thread IDs.  Introduce a helper function
to cover the common part of tests.

While this does not fix all the problems on NetBSD, it enables a subset
of the tests on other systems.  I am planning to add more tests
to the group while implementing multiprocess extension for vCont.

Differential Revision: https://reviews.llvm.org/D98749