[all-commits] [llvm/llvm-project] 425e11: [mlir][AttrTypeDefGen] Add support for custom para...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 425e11eea1de022bd9ea099970b451f77b0a4fca
      https://github.com/llvm/llvm-project/commit/425e11eea1de022bd9ea099970b451f77b0a4fca
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-03-16 (Tue, 16 Mar 2021)

  Changed paths:
    M mlir/docs/OpDefinitions.md
    M mlir/include/mlir/IR/OpBase.td
    M mlir/include/mlir/TableGen/AttrOrTypeDef.h
    M mlir/lib/TableGen/AttrOrTypeDef.cpp
    M mlir/test/mlir-tblgen/attrdefs.td
    M mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

  Log Message:
  -----------
  [mlir][AttrTypeDefGen] Add support for custom parameter comparators

Some parameters to attributes and types rely on special comparison routines other than operator== to ensure equality. This revision adds support for those parameters by allowing them to specify a `comparator` code block that determines if `$_lhs` and `$_rhs` are equal. An example of one of these paramters is APFloat, which requires `bitwiseIsEqual` for bitwise comparison (which we want for attribute equality).

Differential Revision: https://reviews.llvm.org/D98473


  Commit: caa7038a89328bc1e7d1df80f9fcede12dcb7df5
      https://github.com/llvm/llvm-project/commit/caa7038a89328bc1e7d1df80f9fcede12dcb7df5
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-03-16 (Tue, 16 Mar 2021)

  Changed paths:
    M mlir/include/mlir/IR/BuiltinAttributes.h
    M mlir/include/mlir/IR/BuiltinAttributes.td
    M mlir/include/mlir/IR/OpBase.td
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/IR/AttributeDetail.h
    M mlir/lib/IR/BuiltinAttributes.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/lib/Parser/AttributeParser.cpp
    M mlir/lib/TableGen/AttrOrTypeDef.cpp
    M mlir/test/CAPI/ir.c
    M mlir/test/IR/invalid.mlir
    M mlir/test/IR/pretty-attributes.mlir
    M mlir/test/mlir-tblgen/attrdefs.td
    M mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

  Log Message:
  -----------
  [mlir][IR] Move the remaining builtin attributes to ODS.

With this revision, all builtin attributes and types will have been moved to the ODS generator.

Differential Revision: https://reviews.llvm.org/D98474


Compare: https://github.com/llvm/llvm-project/compare/1f13963ec14a...caa7038a8932