[all-commits] [llvm/llvm-project] bcb3f0: [libomptarget] Fix devicertl build

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Mon Mar 15 12:53:10 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bcb3f0f867b27179f9cab49d2ef41fe7769112c0
      https://github.com/llvm/llvm-project/commit/bcb3f0f867b27179f9cab49d2ef41fe7769112c0
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip
    M openmp/libomptarget/deviceRTLs/common/include/target/shuffle.h
    M openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu
    M openmp/libomptarget/deviceRTLs/target_interface.h

  Log Message:
  -----------
  [libomptarget] Fix devicertl build

[libomptarget] Fix devicertl build

The target specific functions in target_interface are extern C, but the
implementations for nvptx were mostly C++ mangling. That worked out as
a quirk of DEVICE macro expanding to nothing, except for shuffle.h which
only forward declared the functions with C++ linkage.

Also implements GetWarpSize, as used by shuffle, and includes target_interface
in nvptx target_impl.cu to help catch future divergence between interface and
implementation.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D98651




More information about the All-commits mailing list