[all-commits] [llvm/llvm-project] 40d8e4: Revert "[Canonicalizer] Process regions top-down i...

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 40d8e4d3f992c5749c949b493e2d0866bc82a451
      https://github.com/llvm/llvm-project/commit/40d8e4d3f992c5749c949b493e2d0866bc82a451
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M mlir/include/mlir/Transforms/FoldUtils.h
    M mlir/lib/Transforms/Utils/FoldUtils.cpp
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
    M mlir/test/Conversion/StandardToSPIRV/legalization.mlir
    M mlir/test/Conversion/VectorToSCF/vector-to-loops.mlir
    M mlir/test/Dialect/Affine/canonicalize.mlir
    M mlir/test/Dialect/Linalg/sparse_2d.mlir
    M mlir/test/Dialect/Linalg/transform-patterns.mlir
    M mlir/test/Dialect/Quant/convert-const.mlir
    M mlir/test/Dialect/SCF/canonicalize.mlir
    M mlir/test/Dialect/SPIRV/Transforms/canonicalize.mlir
    M mlir/test/Dialect/Tensor/canonicalize.mlir
    M mlir/test/Dialect/Vector/canonicalize.mlir
    M mlir/test/Dialect/Vector/vector-contract-transforms.mlir
    M mlir/test/Dialect/Vector/vector-flat-transforms.mlir
    M mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir
    M mlir/test/Dialect/Vector/vector-transfer-unroll.mlir
    M mlir/test/Dialect/Vector/vector-transforms.mlir
    M mlir/test/Transforms/canonicalize.mlir
    M mlir/test/Transforms/parallel-loop-collapsing.mlir
    M mlir/test/Transforms/single-parallel-loop-collapsing.mlir
    M mlir/test/Transforms/test-canonicalize.mlir
    M mlir/test/mlir-tblgen/pattern.mlir

  Log Message:
  -----------
  Revert "[Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants."

This reverts commit b5d9a3c92358349d5444ab28de8ab5b2bee33a01.

The commit introduced a memory error in canonicalization/operation
walking that is exposed when compiled with ASAN. It leads to crashes in
some "release" configurations.