[all-commits] [llvm/llvm-project] 188373: [clangd] Make WorkspaceSymbols request work with e...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 188373fb46979d8141e9f844f13a85157b1ce5dd
      https://github.com/llvm/llvm-project/commit/188373fb46979d8141e9f844f13a85157b1ce5dd
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-03-03 (Wed, 03 Mar 2021)

  Changed paths:
    M clang-tools-extra/clangd/FindSymbols.cpp
    M clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp

  Log Message:
  -----------
  [clangd] Make WorkspaceSymbols request work with empty queries

Clangd uses codecompletion limit as the limit for workspacesymbols, so
in theory this should only be an order of magnitude slower than a
codecompletion request with empty identifier (as code completion limits
the available symbols).

This is also what LSP suggests "Clients may send an empty string here to request all symbols.".
Clangd doesn't really fulfill the "all" part of that statement, but we
never do unless user set the index query limit to zero explicitly.

Differential Revision: https://reviews.llvm.org/D97773