[all-commits] [llvm/llvm-project] 215bb1: [IR] restrict vector reduction intrinsic types

RotateRight via All-commits all-commits at lists.llvm.org
Sun Feb 21 09:37:24 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 215bb15791c6aefdb0810ffa29900dd4215bf8c3
      https://github.com/llvm/llvm-project/commit/215bb15791c6aefdb0810ffa29900dd4215bf8c3
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-02-21 (Sun, 21 Feb 2021)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp
    M llvm/test/Verifier/reduction-intrinsics.ll

  Log Message:
  -----------
  [IR] restrict vector reduction intrinsic types

The arguments in all cases should be vectors of exactly one of integer or FP.

All of the tests currently pass the verifier because we check for any vector
type regardless of the type of reduction.
This obviously can't work if we mix up integer and FP, and based on current
LangRef text it was not intended to work for pointers either.

The pointer case from https://llvm.org/PR49215 is what led me here. That
example was avoided with 5b250a27ec.

Differential Revision: https://reviews.llvm.org/D96904




More information about the All-commits mailing list