[all-commits] [llvm/llvm-project] 3cd70f: Detect diagnostic groups that are defined in multi...

Richard Smith via All-commits all-commits at lists.llvm.org
Thu Feb 18 17:19:31 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3cd70fc59d2a1a907d14bbf3f2dfe53d2c2be9d1
      https://github.com/llvm/llvm-project/commit/3cd70fc59d2a1a907d14bbf3f2dfe53d2c2be9d1
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    R clang/test/TableGen/anonymous-groups.td
    A clang/test/TableGen/redefined-group.td
    R clang/test/TableGen/tg-fixits.td
    M clang/utils/TableGen/ClangDiagnosticsEmitter.cpp

  Log Message:
  -----------
  Detect diagnostic groups that are defined in multiple 'def's.

Remove the three such groups that we've accumulated. These were causing
duplicated output to appear in generated the diagnostic reference.


  Commit: e0589d70fb8e29842fab228df716f73b378710a6
      https://github.com/llvm/llvm-project/commit/e0589d70fb8e29842fab228df716f73b378710a6
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M clang/include/clang/Serialization/ModuleFile.h
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp

  Log Message:
  -----------
  Switch to using LEB encoding for key and data lengths in on-disk hash
tables.

This gives a modest AST file size reduction, while also fixing crashes
in cases where the key or data length doesn't fit into 16 bits.
Unfortunately, such situations tend to require huge test cases (such as
more than 16K modules or an overload set with 16K entries), and I
couldn't get a testcase to finish in a reasonable amount of time, so no
test is included for that bugfix.

No functionality change intended (other than the bugfix).


Compare: https://github.com/llvm/llvm-project/compare/5fb65c02ca5e...e0589d70fb8e


More information about the All-commits mailing list