[all-commits] [llvm/llvm-project] 19db87: [clangd] Drop template argument lists from complet...

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Thu Feb 18 04:10:33 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19db870a0dd1416b2d4a346e2cb17be197193a94
      https://github.com/llvm/llvm-project/commit/19db870a0dd1416b2d4a346e2cb17be197193a94
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

  Log Message:
  -----------
  [clangd] Drop template argument lists from completions followed by <

Now, given `template <typename T> foo() {}` when user types `fo^<int>()` the
completion snippet will not contain `<int>()`.

Also, when the next token is opening parenthesis (`(`) and completion snippet
contains template argument list, it is still emitted.

This patch complements D81380.

Related issue: https://github.com/clangd/clangd/issues/387

Reviewed By: kadircet

Differential Revision: https://reviews.llvm.org/D89870




More information about the All-commits mailing list