[all-commits] [llvm/llvm-project] 8bcc03: [lldb][NFC] Delete deleted const char* overloads o...

[Raphael Isemann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8bcc03767e440f229749d101f470f73b8e1cd2e5
      https://github.com/llvm/llvm-project/commit/8bcc03767e440f229749d101f470f73b8e1cd2e5
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
    M lldb/include/lldb/Interpreter/OptionValueArch.h
    M lldb/include/lldb/Interpreter/OptionValueArray.h
    M lldb/include/lldb/Interpreter/OptionValueBoolean.h
    M lldb/include/lldb/Interpreter/OptionValueChar.h
    M lldb/include/lldb/Interpreter/OptionValueEnumeration.h
    M lldb/include/lldb/Interpreter/OptionValueFileColonLine.h
    M lldb/include/lldb/Interpreter/OptionValueFileSpec.h
    M lldb/include/lldb/Interpreter/OptionValueFileSpecList.h
    M lldb/include/lldb/Interpreter/OptionValueFormat.h
    M lldb/include/lldb/Interpreter/OptionValueFormatEntity.h
    M lldb/include/lldb/Interpreter/OptionValueLanguage.h
    M lldb/include/lldb/Interpreter/OptionValuePathMappings.h
    M lldb/include/lldb/Interpreter/OptionValueRegex.h
    M lldb/include/lldb/Interpreter/OptionValueSInt64.h
    M lldb/include/lldb/Interpreter/OptionValueString.h
    M lldb/include/lldb/Interpreter/OptionValueUInt64.h
    M lldb/include/lldb/Interpreter/OptionValueUUID.h

  Log Message:
  -----------
  [lldb][NFC] Delete deleted const char* overloads of SetValueFromString

This came up during the review of D96817 because those deleted overloads force
the caller to explicitly create a StringRef when passing a string literal.

It seems they were added as some kind of help while migrating the code base to
StringRef in D24847, but I don't think they have any use these days and make
these functions awkward to use.

This patch just removes all the deleted overloads.

Reviewed By: tatyana-krasnukha

Differential Revision: https://reviews.llvm.org/D96861