[all-commits] [llvm/llvm-project] de035c: [GlobalISel] Fix sext_inreg(load) combine to not m...

AE via All-commits all-commits at lists.llvm.org
Thu Feb 11 19:27:27 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: de035c18cf76d442f1f2df5cc417bd03258edec2
      https://github.com/llvm/llvm-project/commit/de035c18cf76d442f1f2df5cc417bd03258edec2
  Author: Amara Emerson <amara at apple.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-sextload-from-sextinreg.mir

  Log Message:
  -----------
  [GlobalISel] Fix sext_inreg(load) combine to not move the originating load.

The builder was using the extend user as the insertion point, which meant that
we were incorrectly "moving" the load from its original position, and therefore
could violate memory operation ordering.




More information about the All-commits mailing list