[all-commits] [llvm/llvm-project] 92ee3d: DebugInfo/Symbolize: Don't differentiate function/...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 92ee3dd95dc666df7c37ccdf3037ced921a519e6
      https://github.com/llvm/llvm-project/commit/92ee3dd95dc666df7c37ccdf3037ced921a519e6
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
    M llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h
    A llvm/test/DebugInfo/Symbolize/ELF/data-command-symtab.yaml

  Log Message:
  -----------
  DebugInfo/Symbolize: Don't differentiate function/data symbolization

Before d08bd13ac8a560c4645e17e192ca07e1bdcd2895, only `SymbolRef::ST_Function`
symbols were used for .symtab symbolization. That commit added a `"DATA"` mode
to llvm-symbolizer which used `SymbolRef::ST_Data` symbols for symbolization.

Since function and data symbols have different addresses, we don't need to
differentiate the two modes. This patches unifies the two modes to simplify
code.

`"DATA"` is used by `compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp`.
`check-hwasan` and `check-tsan` have runtime tests.

Differential Revision: https://reviews.llvm.org/D96322