[all-commits] [llvm/llvm-project] e855cc: AMDGPU/GlobalISel: Remove dead check prefixes

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Feb 8 14:09:48 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e855cc6d04ff540b20ff48cd6bfee3fbf85328b9
      https://github.com/llvm/llvm-project/commit/e855cc6d04ff540b20ff48cd6bfee3fbf85328b9
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.store.2d.d16.ll

  Log Message:
  -----------
  AMDGPU/GlobalISel: Remove dead check prefixes


  Commit: bcf723b2fd6d92e7dd0d7cf4a645a2b1cb974966
      https://github.com/llvm/llvm-project/commit/bcf723b2fd6d92e7dd0d7cf4a645a2b1cb974966
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td

  Log Message:
  -----------
  AMDGPU: Stop adding stack passed wide arguments to call conv handler

The generated calling convention code shouldn't see these types since
we split large types into 32-bit chunks before the calling convention
code is triggered.

GlobalISel ends up directly calls the generated CC code before
checking for the register count breakdown. Arguably this difference is
a bug, but this was dead code for the DAG anyway.


  Commit: 87e280110d91edda0353eddb621cb96f72c7ece3
      https://github.com/llvm/llvm-project/commit/87e280110d91edda0353eddb621cb96f72c7ece3
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/CallLowering.cpp

  Log Message:
  -----------
  GlobalISel: Use correct calling convention in handleAssignments

This was using the calling convention of the calling function, not the
callee. Avoids regressions in a future patch.


Compare: https://github.com/llvm/llvm-project/compare/e84a4650eb7e...87e280110d91


More information about the All-commits mailing list