[all-commits] [llvm/llvm-project] 633c5a: [RISCV] Remove unneeded StringRef to std::string c...

Craig Topper via All-commits all-commits at lists.llvm.org
Sat Jan 16 20:23:59 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 633c5afccfbb0a985976aa3e6493f1a08061cb10
      https://github.com/llvm/llvm-project/commit/633c5afccfbb0a985976aa3e6493f1a08061cb10
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-01-16 (Sat, 16 Jan 2021)

  Changed paths:
    M llvm/utils/TableGen/RISCVCompressInstEmitter.cpp

  Log Message:
  -----------
  [RISCV] Remove unneeded StringRef to std::string conversions in RISCVCompressInstEmitter. NFC

Stop concatenating std::string before streaming into a raw_ostream.
Just stream the pieces.

Remove some new lines from asserts. Remove std::string concatenation
from an assert. assert strings aren't really evaluated like this at
runtime. An assertion failure will just print exactly what's between
the parentheses in the source.




More information about the All-commits mailing list