[all-commits] [llvm/llvm-project] bca16e: [LTO] Remove options to disable inlining, vectoriz...

Florian Hahn via All-commits all-commits at lists.llvm.org
Sat Jan 16 08:43:39 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bca16e2fbb451f125c13f811f9f5a37bb38e54e2
      https://github.com/llvm/llvm-project/commit/bca16e2fbb451f125c13f811f9f5a37bb38e54e2
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2021-01-16 (Sat, 16 Jan 2021)

  Changed paths:
    M llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h
    M llvm/lib/LTO/LTOCodeGenerator.cpp
    M llvm/tools/llvm-lto/llvm-lto.cpp
    M llvm/tools/lto/lto.cpp

  Log Message:
  -----------
  [LTO] Remove options to disable inlining, vectorization & GVNLoadPRE.

This patch removes some ancient options as a clean-up before moving
code-gen to use LTOBackend in D94487.

I think it would preferable to remove those ancient options, because

  1. There are no corresponding options in LTOBackend based tools,
  2. There are no unit tests for them,
  3. They are not passed through by Clang,
  4. At least for GNVLoadPRE, users could just use GVN's `enable-load-pre`.

Alternatively we could add support for those options to lto::Config &
co, but I think it would be better to remove them, unless they are
actually used in practice.

Reviewed By: steven_wu, tejohnson

Differential Revision: https://reviews.llvm.org/D94783




More information about the All-commits mailing list