[all-commits] [llvm/llvm-project] 387d3c: [RISCV] Merge Utils library into MCTargetDesc

Craig Topper via All-commits all-commits at lists.llvm.org
Thu Jan 14 11:48:09 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 387d3c24792f7ab5f2f8aab37d64948f42523825
      https://github.com/llvm/llvm-project/commit/387d3c24792f7ab5f2f8aab37d64948f42523825
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M llvm/lib/Target/RISCV/AsmParser/CMakeLists.txt
    M llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
    M llvm/lib/Target/RISCV/CMakeLists.txt
    M llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/CMakeLists.txt
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.h
    A llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
    A llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp
    A llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.cpp
    A llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.h
    M llvm/lib/Target/RISCV/RISCV.h
    M llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
    M llvm/lib/Target/RISCV/RISCVSubtarget.h
    M llvm/lib/Target/RISCV/RISCVTargetMachine.cpp
    M llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
    R llvm/lib/Target/RISCV/Utils/CMakeLists.txt
    R llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.cpp
    R llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.h
    R llvm/lib/Target/RISCV/Utils/RISCVMatInt.cpp
    R llvm/lib/Target/RISCV/Utils/RISCVMatInt.h

  Log Message:
  -----------
  [RISCV] Merge Utils library into MCTargetDesc

MCTargetDesc includes headers from Utils and Utils includes headers
from MCTargetDesc. So from a library layering perspective it makes sense
for them to be in the same library. I guess the other option might be to
move the tablegen includes from RISCVMCTargetDesc.h to RISCVBaseInfo.h
so that RISCVBaseInfo.h didn't need to include RISCVMCTargetDesc.h.
Everything else that depends on Utils also depends on MCTargetDesc so
having one library seemed simpler.

Differential Revision: https://reviews.llvm.org/D93168




More information about the All-commits mailing list