[all-commits] [llvm/llvm-project] 4b284b: [lldb] Fix TestPlatformProcessConnect.py

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b284b9ca8098e284b8d965a633b71bd283043d6
      https://github.com/llvm/llvm-project/commit/4b284b9ca8098e284b8d965a633b71bd283043d6
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbtest.py
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
    M lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py

  Log Message:
  -----------
  [lldb] Fix TestPlatformProcessConnect.py

The test was marked as remote-only, which means it was run ~never, and
accumulated various problems. This commit modifies the test to run
locally and includes a couple of other fixes necessary to make it run:
- moves the "invoke" method into the "Base" test class
- adds []'s around the IP address in a couple more places to make things
  work with IPv6

The test is now marked as skipped when running the remote test suite. It
would be possible to make it run both locally and remotely, but this
would require writing a lot special logic for the remote case, and that
is not worth it.