[all-commits] [llvm/llvm-project] 7ec8f4: [SPARC] Fix fp128 load/stores

Craig Topper via All-commits all-commits at lists.llvm.org
Wed Jan 13 15:02:51 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ec8f43659861be42f9d600422678196849b6e90
      https://github.com/llvm/llvm-project/commit/7ec8f43659861be42f9d600422678196849b6e90
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-01-13 (Wed, 13 Jan 2021)

  Changed paths:
    M llvm/lib/Target/Sparc/SparcISelLowering.cpp
    A llvm/test/CodeGen/SPARC/fp128-split.ll

  Log Message:
  -----------
  [SPARC] Fix fp128 load/stores

The generated code for the split fp128 load/stores was missing a small yet important adjustment to the pointer metadata being fed into `getStore` and `getLoad`, making it out of sync with the effective memory address.
This problem often resulted in instructions being scheduled in the wrong order.

I also took this chance to clean up some "wrong" uses of `getAlignment` as done in D77687.

Thanks @jrtc27 for finding the problem and providing a patch.

Patch by LemonBoy and Jessica Clarke(jrtc27)

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D94345




More information about the All-commits mailing list