[all-commits] [llvm/llvm-project] 2a49b7: [Inliner] Change inline remark format and update R...

[modiking via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2a49b7c64a33566cf5db1a5b4042d6037ccc7cf5
      https://github.com/llvm/llvm-project/commit/2a49b7c64a33566cf5db1a5b4042d6037ccc7cf5
  Author: modimo <modimo at fb.com>
  Date:   2021-01-12 (Tue, 12 Jan 2021)

  Changed paths:
    M clang/test/Frontend/optimization-remark-with-hotness-new-pm.c
    M clang/test/Frontend/optimization-remark-with-hotness.c
    M llvm/include/llvm/Analysis/InlineAdvisor.h
    M llvm/include/llvm/Analysis/ReplayInlineAdvisor.h
    M llvm/lib/Analysis/InlineAdvisor.cpp
    M llvm/lib/Analysis/ReplayInlineAdvisor.cpp
    M llvm/lib/Transforms/IPO/SampleProfile.cpp
    M llvm/test/Transforms/Inline/optimization-remarks-passed-yaml.ll
    M llvm/test/Transforms/SampleProfile/Inputs/inline-replay.txt
    M llvm/test/Transforms/SampleProfile/inline-replay.ll
    M llvm/test/Transforms/SampleProfile/remarks-hotness.ll
    M llvm/test/Transforms/SampleProfile/remarks.ll

  Log Message:
  -----------
  [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

This change modifies the source location formatting from:
LineNumber.Discriminator
to:
LineNumber:ColumnNumber.Discriminator

The motivation here is to enhance location information for inline replay that currently exists for the SampleProfile inliner. This will be leveraged further in inline replay for the CGSCC inliner in the related diff.

The ReplayInlineAdvisor is also modified to read the new format and now takes into account the callee for greater accuracy.

Testing:
ninja check-llvm

Reviewed By: mtrofin

Differential Revision: https://reviews.llvm.org/D94333