[all-commits] [llvm/llvm-project] a81c68: [OpenMP] Take elf_common.c as a interface library
Shilei Tian via All-commits
all-commits at lists.llvm.org
Mon Jan 11 14:39:22 PST 2021
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: a81c68ae6be58efa24e2573e155d5ef20260399b
https://github.com/llvm/llvm-project/commit/a81c68ae6be58efa24e2573e155d5ef20260399b
Author: Shilei Tian <tianshilei1992 at gmail.com>
Date: 2021-01-11 (Mon, 11 Jan 2021)
Changed paths:
M openmp/libomptarget/plugins/CMakeLists.txt
M openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
M openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
A openmp/libomptarget/plugins/common/CMakeLists.txt
R openmp/libomptarget/plugins/common/elf_common.c
A openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt
A openmp/libomptarget/plugins/common/elf_common/elf_common.h
M openmp/libomptarget/plugins/cuda/CMakeLists.txt
M openmp/libomptarget/plugins/cuda/src/rtl.cpp
M openmp/libomptarget/plugins/generic-elf-64bit/src/rtl.cpp
M openmp/libomptarget/plugins/ve/CMakeLists.txt
M openmp/libomptarget/plugins/ve/src/rtl.cpp
Log Message:
-----------
[OpenMP] Take elf_common.c as a interface library
For now `elf_common.c` is taken as a common part included into
different plugin implementations directly via
`#include "../../common/elf_common.c"`, which is not a best practice. Since it
is simple enough such that we don't need to create a real library for it, we just
take it as a interface library so that other targets can link it directly. Another
advantage of this method is, we don't need to add the folder into header search
path which can potentially pollute the search path.
VE and AMD platforms have not been tested because I don't have target machines.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D94443
More information about the All-commits
mailing list